-
Notifications
You must be signed in to change notification settings - Fork 0
8 point filtering #39
Merged
81d2c465c1e79b17ea5c062ba02f7c65d24ab30
merged 11 commits into
dev
from
8-point-filtering
Oct 24, 2025
+741
−141
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e2b778c
feat(#8): :sparkles: Made functionaliry for Accepted filtering
eae6463
perf(#8): :zap: Optimize elevation control and accepted filtering
3b79c44
style(#8): :bulb: Update the comments and clean the code
76a18d8
test(#8): :test_tube: Made tests for elevation control and accepted f…
7fcbf1e
fix(#8): :bug: Elevation needs to be activated upon initiation
9ef64a3
feat(#8): :sparkles: Filter based on acceted/not accepted
82aed3a
chore:
2ea2c33
revert(#8): :fire: Remove elevation control and accepted filtering fi…
8b54df5
refactor(#8): :adhesive_bandage: Adjusted to PR comments
c7c56a4
refactor: :twisted_rightwards_arrows: Resolve mergeconflict with dev …
c8e0895
refactor: :bug: One missing import fixed from the merge in the prev c…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /**Testing whether the Accepted components excists or not */ | ||
| describe('Accepted filtering', () => { | ||
| it('test accepted filter button', function () { | ||
| cy.visit('http://localhost:5173/#') | ||
| cy.get('#doAcceptedFilter').click() | ||
| }) | ||
| }) | ||
|
|
||
| /**Testing whether the Elevation components excists or not */ | ||
| describe('Elevation Control', () => { | ||
| it('test elevation control', function () { | ||
| cy.visit('http://localhost:5173/#') | ||
| cy.get('#btnDoElevationControl').click() | ||
|
|
||
| cy.get( | ||
| '#elevation_gradient_scheme_selection span:nth-child(8) rect' | ||
| ).click() | ||
| cy.get( | ||
| '#elevation_gradient_scheme_selection span:nth-child(3) rect' | ||
| ).click() | ||
|
|
||
| cy.get('#sldHeightRange').click() | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,149 @@ | ||
| /* ---------- Buttons (shared look) ---------- */ | ||
| /* Reuse your accepted button style for all four */ | ||
| #btnDoElevationControl, | ||
| #doAcceptedFiltering, | ||
| #btnTHU, | ||
| #btnTVU, | ||
| #btnTHUFilter { | ||
| display: flex; | ||
| width: 100%; | ||
| margin: 6px 0 10px; | ||
| padding: 10px 10px; | ||
| font-size: 13px; | ||
| font-weight: 500; | ||
| background-color: #636262; | ||
| color: #ffffff; | ||
| border: 1px solid #555; | ||
| border-radius: 4px; | ||
| cursor: pointer; | ||
| transition: | ||
| background-color 0.2s ease, | ||
| transform 0.1s ease; | ||
| } | ||
|
|
||
| #btnDoElevationControl:hover, | ||
| #doAcceptedFiltering:hover, | ||
| #btnTHU:hover, | ||
| #btnTVU:hover, | ||
| #btnTHUFilter:hover { | ||
| background-color: #8f8f8f; | ||
| } | ||
|
|
||
| #btnDoElevationControl:active, | ||
| #doAcceptedFiltering:active, | ||
| #btnTHU:active, | ||
| #btnTVU:active, | ||
| #btnTHUFilter:active { | ||
| transform: scale(0.97); | ||
| background-color: #a8a6a6; | ||
| } | ||
|
|
||
| /* Optional: “active mode” outline if you toggle a class via JS */ | ||
| #btnDoElevationControl.active, | ||
| #doAcceptedFiltering.active, | ||
| #btnTHU.active, | ||
| #btnTVU.active, | ||
| #btnTHUFilter:active { | ||
| outline: 2px solid #7ba8ff; | ||
| outline-offset: 1px; | ||
| } | ||
|
|
||
| /* THU/TVU side-by-side */ | ||
| #thu_tvu_list .thu-tvu-row { | ||
| display: flex; | ||
| gap: 6px; | ||
| } | ||
| #thu_tvu_list .thu-tvu-row > button { | ||
| flex: 1 1 50%; | ||
| margin: 0; | ||
| } | ||
81d2c465c1e79b17ea5c062ba02f7c65d24ab30 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /* ---------- Panels / moved containers ---------- */ | ||
| /* Keep Potree’s moved subtrees neat and full-width inside our panels */ | ||
| #elevation2_list [id='materials.elevation_container'], | ||
| #thu_tvu_list [id='materials.extra_container'] { | ||
| width: 100%; | ||
| box-sizing: border-box; | ||
| padding: 6px 8px; /* small breathing room since we moved it out of Appearance */ | ||
| } | ||
|
|
||
| /* Slight spacing inside our panel lists (under the button) */ | ||
| #elevation2_list, | ||
| #accepted_list_host, | ||
| #thu_tvu_list { | ||
| display: block; | ||
| padding: 4px 0; | ||
| } | ||
|
|
||
| /* A small notice style used when an attribute/panel isn’t available */ | ||
| .panel-notice { | ||
| font-size: 13px; | ||
| color: #ddd; | ||
| background: rgba(255, 255, 255, 0.04); | ||
| border: 1px dashed #666; | ||
| border-radius: 4px; | ||
| padding: 8px; | ||
| margin: 6px 0; | ||
| } | ||
|
|
||
| /* ---------- Elevation label + slider tweaks ---------- */ | ||
| #lblHeightRange { | ||
| display: inline-block; | ||
| font-size: 12px; | ||
| color: #ddd; | ||
| margin: 4px 0 6px 2px; | ||
| } | ||
|
|
||
| /* Make sure the jQuery-UI slider has a little vertical room */ | ||
| #sldHeightRange { | ||
| margin: 6px 4px 10px 4px; | ||
| } | ||
|
|
||
| /* ---------- Accordions / headers (light touch) ---------- */ | ||
| /* Don’t fight jQuery-UI’s theme. Just small spacing adjustments. */ | ||
| #menu_elevation2 + .pv-menu-list, | ||
| #menu_accepted + .pv-menu-list, | ||
| #menu_thu_tvu + .pv-menu-list { | ||
| padding-top: 6px; | ||
| } | ||
|
|
||
| /* Optional: header label color alignment with dark UI */ | ||
| #menu_elevation2 span, | ||
| #menu_accepted span, | ||
| #menu_thu_tvu span { | ||
| color: #e6e6e6; | ||
| font-weight: 600; | ||
| letter-spacing: 0.2px; | ||
| } | ||
|
|
||
| /* Legend container */ | ||
| #accepted_legend { | ||
| margin-top: 10px; | ||
| padding-left: 4px; | ||
| } | ||
|
|
||
| /* Legend rows */ | ||
| #accepted_legend .legend-row { | ||
| display: flex; | ||
| align-items: center; | ||
| margin: 3px 0; | ||
| font-size: 13px; | ||
| color: #ddd; /* visible text */ | ||
| } | ||
|
|
||
| /* Color boxes */ | ||
| #accepted_legend .legend-color { | ||
| width: 16px; | ||
| height: 16px; | ||
| border: 1px solid #777; | ||
| margin-right: 8px; | ||
| border-radius: 2px; | ||
| } | ||
|
|
||
| #accepted_legend .legend-color.accepted { | ||
| background-color: #fff; | ||
| } | ||
|
|
||
| #accepted_legend .legend-color.not-accepted { | ||
| background-color: #000; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.