Skip to content

53 Inital target point #54

Merged
merged 1 commit into from
Oct 30, 2025
Merged

53 Inital target point #54

merged 1 commit into from
Oct 30, 2025

Conversation

kleinc
Copy link
Member

@kleinc kleinc commented Oct 29, 2025

Issue number

Closes 53

Description

Solved the issue where the initial target position showed the elevation as -70 000, by changing the initial target point to be that of a random point

Testing steps

Start the application and see that target elevation is -2207.6003 m

Screenshots (optional)

Summary by CodeRabbit

  • Updates
    • Adjusted the default starting camera position in the 3D viewer for an updated initial perspective.

@kleinc kleinc self-assigned this Oct 29, 2025
@kleinc kleinc linked an issue Oct 29, 2025 that may be closed by this pull request
@coderabbit
Copy link

coderabbit bot commented Oct 29, 2025

Walkthrough

The initial camera target coordinates in the Potree viewer were updated from [1500922.651, 510673.03, 5427934.722] to [1821061.22, 266704.21, 6084038.77]. No logic or control flow modifications were made.

Changes

Cohort / File(s) Change Summary
Camera target initialization
src/potreeViewer.js
Updated initial camera target point coordinates from [1500922.651, 510673.03, 5427934.722] to [1821061.22, 266704.21, 6084038.77]

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single numeric parameter update with no logic implications

Poem

🐰 A viewer's eye shifts through the sky,
New coordinates reach way up high,
From one perspective to brand new sights,
The camera pans to better heights! ✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between b4a0e8c and b476006.

📒 Files selected for processing (1)
  • src/potreeViewer.js (1 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@kleinc kleinc changed the title refactor(#53): ♻️ Change inital target position 53 Change inital target position Oct 29, 2025
@kleinc kleinc changed the title 53 Change inital target position 53 Inital target point Oct 29, 2025
@mariewah mariewah self-requested a review October 30, 2025 09:35
Copy link
Member

@mariewah mariewah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

Copy link
Member

@franmagn franmagn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kleinc kleinc merged commit 0711b75 into dev Oct 30, 2025
2 checks passed
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial target points fix
3 participants