-
Notifications
You must be signed in to change notification settings - Fork 0
fix(#61): 🐛 Ensure potreeViewer is always enabled #62
Conversation
WalkthroughDefines a local constant referencing Changes
Sequence Diagram(s)sequenceDiagram
participant Potree as Potree Init
participant Win as window
participant Consumer as Downstream Code
Potree->>Win: create `window.potreeViewer`
Note right of Win `#f0f4c3`: Alias assignment (new)
Win->>Win: const potreeViewer = window.potreeViewer\nwindow.viewer = window.potreeViewer
Consumer->>Win: read `window.viewer` (uses alias)
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Free 📒 Files selected for processing (1)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, the test worked as intended. 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, now everything works fine!
Issue number
Closes #61
Description
Ensure potreeViewer is always enabled
Testing steps
Try to make a camera animation, find it under scene, and play it
Summary by CodeRabbit