Skip to content
Jump to bottom

Fix precision loss in conversion #2

Merged
merged 2 commits into from
Oct 15, 2025
Merged

Fix precision loss in conversion #2

merged 2 commits into from
Oct 15, 2025
+26 −48

Conversation

adriahso
Copy link
Member

Issue number

Closes #1

Description of change

Made it so that decimals are kept during the conversion so that we don't loose precision.

Testing steps

  • Try running the conversion and check that it works.
  • Also check whether you see a difference in the precision of the point cloud.

@adriahso adriahso requested a review from tobiaobr October 15, 2025 11:51
@adriahso adriahso self-assigned this Oct 15, 2025
@adriahso adriahso linked an issue Oct 15, 2025 that may be closed by this pull request
Fix precision error in conversion #1
Closed
franmagn
franmagn approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@franmagn franmagn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tobiaobr
tobiaobr requested changes Oct 15, 2025
View reviewed changes
Copy link
Member

@tobiaobr tobiaobr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove redundant parameter in csv2las method. Otherwise looks good

@adriahso adriahso requested a review from tobiaobr October 15, 2025 12:00
@adriahso adriahso merged commit bedebd3 into main Oct 15, 2025
@adriahso adriahso deleted the 1-fix-precision-error-in-conversion branch October 15, 2025 12:02
Sign in to join this conversation on GitHub.
Reviewers

@tobiaobr tobiaobr tobiaobr approved these changes

@franmagn franmagn franmagn approved these changes

Assignees

@adriahso adriahso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix precision error in conversion
3 participants
@adriahso @tobiaobr @franmagn