Merge 60 with develop #61
Merged
+433
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added loboBlob as a parameter with setter-getter.
Updated selenium dependency to latest.
Added a class that facilitates downloading of .png to blob, and conversion from blob to .png.
Added a simple test for the conversion method.
Fixed some selectors so that they are more reliable. Should get all values from IK now.
Added JavaDoc text to logoBlob setter.
Made URLScraper run before the preparedStatement as it takes forever to go through all the charities (around 1.5 to 2 hours), and the server connection would time out before it finished. Run LogoDownloader after the URLScraper to get the blob for the image. Added all the new parameters to getCharitiesFromDB method. Added some JavaDoc to getCharitiesFromDB and addAPIDataToTable.
Added an example of how the LogoDownloader convertBlobToPNG method works in practice (blobImageTest()).
Added javaDoc.
Added filter to remove charities with status="obs" (aka charities removed from IK).
Added case for if blob == null.
Removed unused imports.
…mutviklingTeam6 into 60-download-charity-logo
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.