refactor: Model classes based on test results.

src/main/java/edu/ntnu/idi/idatt/model/market/Newspaper.java

@@ -6,8 +6,6 @@
 
 import edu.ntnu.idi.idatt.model.enums.NewspaperEnum;
 
-//TODO: junit
-
 /**
  * Newspaper class
  *

src/main/java/edu/ntnu/idi/idatt/model/market/Stock.java

@@ -123,8 +123,8 @@ public BigDecimal getLatestPriceChangePercent() {
       return BigDecimal.ZERO;
     }
 
-    return (getLatestPriceChange().divide(prices.get(prices.size() - 2), 2, RoundingMode.HALF_UP))
-        .multiply(new BigDecimal("100"));
+    return (getLatestPriceChange().multiply(new BigDecimal("100"))
+        .divide(prices.get(prices.size() - 2), 2, RoundingMode.HALF_UP));
   }
 
   /**

src/main/java/edu/ntnu/idi/idatt/model/portfolio/Portfolio.java

@@ -142,9 +142,6 @@ public BigDecimal getChangeFromStock() {
     BigDecimal costTotal = getShares().stream().map(s -> s.getTotalPurchasePrice())
         .reduce(BigDecimal.ZERO, BigDecimal::add);
 
-    if (costTotal.compareTo(BigDecimal.ZERO) <= 0)
-      return BigDecimal.ZERO;
-
     return profitTotal.divide(costTotal, 2, RoundingMode.HALF_UP).multiply(BigDecimal.valueOf(100));
   }
 

src/main/java/edu/ntnu/idi/idatt/view/components/elements/StockComponent.java

@@ -54,7 +54,7 @@ public StockComponent(Stock stock) {
     CssUtils.apply(title, CssUtils.BIG_TEXT_32);
     labels.forEach(l -> CssUtils.apply(l, CssUtils.MED_TEXT_16));
 
-    String color = CssUtils.generateValueColors(stock.getLatestPriceChange().doubleValue());
+    String color = CssUtils.generateValueColors(stock.getLatestPriceChange());
     CssUtils.apply(changeValue, color);
     CssUtils.apply(changeValuePercent, color);