Skip to content

Commit

Permalink
Update: tests were updated in attempt to be correct on prod
Browse files Browse the repository at this point in the history
  • Loading branch information
mauritzs committed Mar 31, 2025
1 parent 59d304d commit 1e963df
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test_dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
push:
branches: [main]
pull_request:
branches: [main, develop]
branches: [main]

jobs:
test:
Expand Down
16 changes: 8 additions & 8 deletions backend/tests/test_workout_file_upload.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ class TestWorkoutFileUpload(TestCase):
def setUp(self):
self.client = APIClient()
# Use environment variables if available, otherwise use test defaults
username = os.getenv("DJANGO_SUPERUSER_USERNAME", "admin")
password = os.getenv("DJANGO_SUPERUSER_PASSWORD", "Password") # Not good practice to have the password in the code, should use github secrets
username = "Mauritz"
password = "Testtest123?" # Not good practice to have the password in the code, should use github secrets

self.user = get_user_model().objects.create_user(
username=username,
Expand All @@ -28,7 +28,7 @@ def test_upload_multiple_valid_pdf_files(self):
f'file{i}.pdf', b'%PDF-1.4 example PDF content' * 1024, content_type='application/pdf'
) for i in range(8)}
response = self.client.post(self.url, files, format='multipart')
self.assertEqual(response.status_code, 403) # Should be 201
self.assertEqual(response.status_code, 201) # Should be 201

# workout_files = WorkoutFile.objects.all()
# self.assertEqual(workout_files.count(), 8)
Expand All @@ -37,29 +37,29 @@ def test_upload_file_of_maximum_size(self):
file_content = b'X' * (2 * 1024 * 1024) # 2MB file
file = SimpleUploadedFile("max_size.pdf", file_content, content_type='application/pdf')
response = self.client.post(self.url, {"file": file}, format='multipart')
self.assertEqual(response.status_code, 403) # Should be 201
self.assertEqual(response.status_code, 201) # Should be 201

def test_upload_maximum_number_of_files(self):
files = {f'file{i}': SimpleUploadedFile(
f'file{i}.pdf', b'%PDF-1.4 example PDF content' * 1024, content_type='application/pdf'
) for i in range(10)}
response = self.client.post(self.url, files, format='multipart')
self.assertEqual(response.status_code, 403) # Should be 201
self.assertEqual(response.status_code, 201) # Should be 201

def test_upload_file_with_size_just_above_limit(self):
file_content = b'X' * (2 * 1024 * 1024 + 1) # Slightly above 2MB
file = SimpleUploadedFile("above_limit.pdf", file_content, content_type='application/pdf')
response = self.client.post(self.url, {"file": file}, format='multipart')
self.assertEqual(response.status_code, 403) # Should be 400
self.assertEqual(response.status_code, 400) # Should be 400

def test_upload_too_many_files(self):
files = {f'file{i}': SimpleUploadedFile(
f'file{i}.pdf', b'%PDF-1.4 example PDF content' * 1024, content_type='application/pdf'
) for i in range(11)} # Assuming limit is 10, this exceeds it
response = self.client.post(self.url, files, format='multipart')
self.assertEqual(response.status_code, 403) # Should be 400
self.assertEqual(response.status_code, 400) # Should be 400

def test_upload_invalid_file_type(self):
file = SimpleUploadedFile("invalid.txt", b'Invalid content', content_type='text/plain')
response = self.client.post(self.url, {"file": file}, format='multipart')
self.assertEqual(response.status_code, 403) # Should be 400
self.assertEqual(response.status_code, 400) # Should be 400

0 comments on commit 1e963df

Please sign in to comment.