Skip to content

Unit tests are created for the existing components, and current available functionality #22

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2026
Merged

Unit tests are created for the existing components, and current available functionality #22

merged 1 commit into from
Oct 5, 2026
+468 −0

Conversation

vitaliyb
Copy link
Member

@vitaliyb vitaliyb commented Oct 5, 2026

Unit tests for the 4 components, and the functions using mocking for test data.

@vitaliyb vitaliyb requested a review from a team as a code owner October 5, 2026 08:50
@vitaliyb vitaliyb linked an issue Oct 5, 2026 that may be closed by this pull request
Unit tests #21
Closed
asgeija
asgeija approved these changes Oct 5, 2026
View reviewed changes
Copy link
Member

@asgeija asgeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asgeija asgeija merged commit 83d0eb5 into main Oct 5, 2026
@asgeija asgeija deleted the 21-unit-tests branch October 5, 2026 10:59
asgeija added a commit that referenced this pull request Oct 5, 2026
@asgeija
Test: fix Banner and hooks tests after merge
700060d 
The submit form (#46) made Banner use router links and useSighting
read from a store, which broke the tests added in #22. Wraps Banner
in a MemoryRouter, looks for the title as a link and runs useSighting
inside renderHook. No production code changes.
Sign in to join this conversation on GitHub.
Reviewers

@asgeija asgeija asgeija approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit tests
2 participants
@vitaliyb @asgeija