feat: expose design tokens as Tailwind utilities #61
+83
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2026
xeniag
reviewed
Oct 16, 2026
| --color-accent-color: var(--accent-color); | ||
| --color-background-color: var(--background-color); | ||
| --color-background-color-element: var(--background-color-element); | ||
| --color-text-color: var(--text-color); |
There was a problem hiding this comment.
the variable --text-color is not defined anywhere in root. consider changing this to --text or --text-h
There was a problem hiding this comment.
isn't --text-color is defined in src/styles/variables.css?
There was a problem hiding this comment.
Oh, ok I thought this was meant to override variables.css, then its ok :)
|
A few things need fixing before merging:
Written by Claude Code |
- Give --text-color a dark value so headings are readable in dark mode. - Rename the D-value --background-color to --badge-d-value-bg (it overrode the page background) and add --badge-d-value-text for light mode. - Move the dark token block out of :root so data-theme="dark" works on <html>, as in src/index.css. - README: fonts are Faustina and Inter now, not system fonts.
xeniag
approved these changes
Oct 18, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Expose the existing design tokens as Tailwind utilities and connect the UI fonts.
What's in it
docs/AI_USAGE.md.Choices
Reference the existing CSS variables instead of introducing duplicate palette values. This is the theme foundation required by #48.
Testing
git diff --checkpassed.npm run buildwas skipped and remains to be run before this PR is marked ready.Not done (still open)
Closes #60
Generated with GitHub Copilot