fix: build, reload 404, search requests and ingredient list #11
+197
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tsc -b failed on 'global', which is Node only and unknown to the browser tsconfig
* Add .htaccess with FallbackResource for /project2/ * Document the Apache AllowOverride setting needed on the VM
* Add useDebounce hook with tests * Search field keeps its own state and updates the URL 300 ms after typing stops
* Add splitIngredients that keeps notes like 'or as needed' with their ingredient * A comma starts a new item when the next part has a quantity or is a no-quantity ingredient like salt * Add tests based on real recipes from the dataset
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7, closes #8, closes #9, closes #10
globalin the fetch mock. UsesglobalThisnow,npm run buildpasses again/project2/recipe/:idgave a 404. Addsclient/public/.htaccesswithFallbackResourceand a README note on the Apache setting needed on the VMsplitIngredientsonly starts a new item when the next part has a quantity or is a no-quantity ingredient like salt or cooking spray.