Skip to content

Conversation

martakam
Copy link
Member

@martakam martakam commented Oct 2, 2026

Adds multiple Shadcn components that we'll likely use.
If any of them won't be used, we can always remove them later on.

Note on the Shadcn CLI usage:
When adding new components using the CLI, the file names will be in kebab-case.tsx, for example alert-dialog.tsx.
We use PascalCase.tsx, so that would be AlertDialog.tsx instead.

If you'll import new components, please make sure to change the casing of the files in order to match.
A note about this will be added to CONTRIBUTING.md once #15 is merged.

This adds what we'll realistically use.
If we do not end up using everything, we may always remove some.
@martakam martakam requested a review from a team as a code owner October 2, 2026 18:44
@martakam martakam added this to the Deliverable 2 milestone Oct 2, 2026
@martakam martakam added the enhancement New feature or request label Oct 2, 2026
@martakam martakam self-assigned this Oct 2, 2026
@martakam martakam linked an issue Oct 2, 2026 that may be closed by this pull request
@johahor
Copy link
Member

johahor commented Oct 7, 2026

Looks good in general, but one thing i notices was in the index.css file.

There are two @theme blocks, and the second one is the one that wins. One place i notices a problem was in the "Previous" and "Next" buttons. I'll provide an image as well.
Skjermbilde 2026-10-07 kl  17 49 16

This is not the biggest issue, and since @hestro is planning to convert out components to Shadcn, I'm fine with approving this, and getting it merged, so that the important backend/database work can build on top of this to avoid possible conflicts. #22 moves all frontent files to /frontend, so that will probably get conflicts. Better to fix now, than later. So my suggestion is merge this as is, and update #22 with the updated main, and then continue the backend work. Then @hestro can work independently on the frontend while others work on the backend without worrying about conflicts.

@martakam
Copy link
Member Author

martakam commented Oct 7, 2026

The index.css file and the general look should be improved now. When components are changed to use Shadcn, the usage of colors and borders should also become more standardized. For example, all buttons will be using the component Button from Shadcn with predefined styling for different variants (default, secondary, destructive, etc).

@johahor
Copy link
Member

johahor commented Oct 7, 2026

Looks good, approving. Delivery 2 isn't that centered around perfect UI, so make the UI spotless is something we can deal with later. Now we have the tools to do it, so good work.

@martakam martakam merged commit 32206e3 into main Oct 7, 2026
@martakam martakam deleted the feat/add-shadcn branch October 7, 2026 18:45
Sign in to join this conversation on GitHub.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add basic shadcn components
2 participants