-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add Shadcn components #21
Conversation
This adds what we'll realistically use. If we do not end up using everything, we may always remove some.
|
Looks good in general, but one thing i notices was in the index.css file. There are two @theme blocks, and the second one is the one that wins. One place i notices a problem was in the "Previous" and "Next" buttons. I'll provide an image as well. This is not the biggest issue, and since @hestro is planning to convert out components to Shadcn, I'm fine with approving this, and getting it merged, so that the important backend/database work can build on top of this to avoid possible conflicts. #22 moves all frontent files to /frontend, so that will probably get conflicts. Better to fix now, than later. So my suggestion is merge this as is, and update #22 with the updated main, and then continue the backend work. Then @hestro can work independently on the frontend while others work on the backend without worrying about conflicts. |
This is now applied to all elements automatically
Adjusted the accent to have a colors for buttons like these
|
The |
|
Looks good, approving. Delivery 2 isn't that centered around perfect UI, so make the UI spotless is something we can deal with later. Now we have the tools to do it, so good work. |
Adds multiple Shadcn components that we'll likely use.
If any of them won't be used, we can always remove them later on.
Note on the Shadcn CLI usage:
When adding new components using the CLI, the file names will be in
kebab-case.tsx, for examplealert-dialog.tsx.We use
PascalCase.tsx, so that would beAlertDialog.tsxinstead.If you'll import new components, please make sure to change the casing of the files in order to match.
A note about this will be added to
CONTRIBUTING.mdonce #15 is merged.