Skip to content

Conversation

martakam
Copy link
Member

@martakam martakam commented Oct 3, 2026

This is a small PR which adds the backend server running Express for our application.
The next natural step would be adding GraphQL, since we will not be using classic REST.
After that, we must also add a database to store our data.

All of this will be added in separate PRs which build upon this one, so the backend is in no way complete yet.

@martakam martakam requested a review from a team as a code owner October 3, 2026 16:33
@martakam martakam self-assigned this Oct 3, 2026
@martakam martakam added the enhancement New feature or request label Oct 3, 2026
@martakam martakam added this to the Deliverable 2 milestone Oct 3, 2026
@martakam martakam linked an issue Oct 3, 2026 that may be closed by this pull request
@johahor
Copy link
Member

johahor commented Oct 7, 2026

Good work on the initial setup! A couple of things that should be fixed before merge.

.gitignore will stop working with this setup, and I see that you have fixed this in #23 on commit af09012, but it should added to this PR in case we merge this into main, and #23 takes some time to get merged as well. If you plan to merge them together, it's fine to leave as is. l

The README.md file references stale paths, some examples app/test, app/api, app/api/types.ts. I will also comment specifically on these lines in another review comment, so treat this as a general comment for it.

"Hello world!" works in localhost:3001, good good.

@johahor
Copy link
Member

johahor commented Oct 7, 2026 •

Good work on the initial setup! A couple of things that should be fixed before merge.

.gitignore will stop working with this setup, and I see that you have fixed this in #23 on commit af09012, but it should added to this PR in case we merge this into main, and #23 takes some time to get merged as well. If you plan to merge them together, it's fine to leave as is. l

The README.md file references stale paths, some examples app/test, app/api, app/api/types.ts. I will also comment specifically on these lines in another review comment, so treat this as a general comment for it.

"Hello world!" works in localhost:3001, good good.

It might be better to just merge PR 22-24 in one go (you might have already planned to do this), and approve this right away as is. I see you made some changes to documentation in #24, and it is probably better to make all documentation changes in that one, to avoid having to rebase the stacked PR's with this one.

Tell me what you think, and I'll approve if you agree.

@martakam
Copy link
Member Author

martakam commented Oct 7, 2026

Yes, these PRs should likely be merged together. Any issues that are more relevant in the next PRs can be resolved there

@martakam martakam merged commit 1df10e3 into main Oct 7, 2026
@martakam martakam deleted the feat/basic-express-server branch October 7, 2026 18:45
@martakam martakam restored the feat/basic-express-server branch October 7, 2026 18:49
Sign in to join this conversation on GitHub.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add basic express server for the backend
2 participants