Skip to content

Updated nginx runner setup following Exercise requirements #1

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

jddubois
Copy link
Collaborator

@jddubois jddubois commented Mar 4, 2025

Just modified two lines to match what is written on BB. Small PR.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these changes are relative to how our server looks? Meaning this might be correct for your case, but I believe it is incorrect for my case, again highlighting the concurrency issues we have here. Maybe we should contact the TA again and ask how we should solve the issue of cooperating in one repo with only limited access for one of the parties...

Copy link
Owner

@mauritzs mauritzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment that should be considered.

@mauritzs mauritzs merged commit 97c6e61 into main Mar 13, 2025
1 check passed
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants