Skip to content

Updated nginx runner setup following Exercise requirements #1

Merged
merged 2 commits into from
Mar 13, 2025
+3 −3
Merged

Updated nginx runner setup following Exercise requirements #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26644da
fix: changed file name and last cmd nginx config to match exercises r…
Mar 4, 2025
de49f3e
fix
Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/update_primary_nginx.yml
View file
Open in desktop
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these changes are relative to how our server looks? Meaning this might be correct for your case, but I believe it is incorrect for my case, again highlighting the concurrency issues we have here. Maybe we should contact the TA again and ask how we should solve the issue of cooperating in one repo with only limited access for one of the parties...

Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ jobs:

- name: Replace environment variables in Nginx config
run: |
envsubst '${DEV_PORT_PREFIX} ${PROD_PORT_PREFIX} ${STAG_PORT_PREFIX} ${GATEWAY_POSTFIX}' < nginx_template.txt > nginx_secfit.conf
envsubst '${DEV_PORT_PREFIX} ${PROD_PORT_PREFIX} ${STAG_PORT_PREFIX} ${GATEWAY_POSTFIX}' < nginx_template.txt > ./nginx_securefit.conf

- name: Copy variables to conf file
run: |
sudo cp nginx_secfit.conf /etc/nginx/conf.d/nginx.conf
sudo cp ./nginx_securefit.conf /etc/nginx/conf.d/nginx.conf

- name: Test setup
run: |
Expand All @@ -47,4 +47,4 @@ jobs:
# Restarting nginx service
- name: Restart nginx service
run: |
sudo systemctl restart nginx
sudo systemctl reload nginx
0 nginx_secfit.conf → nginx_securefit.conf
View file
Open in desktop
File renamed without changes.
Loading