fix: add listener lifecycle management and confirmSetup error handling #59

francinv · 2026-04-06T20:42:57Z

Closes #52
Closes #53

Track all Firebase listeners via cleanup runnables in AndroidFirebase
Add removeAllListeners() to FirebaseAPI interface
Add stop() to GameNetworkHandler, called from GameScreen hide/dispose
Fix confirmSetup: propagate errors to onError callback instead of silently calling onSuccess on failure paths
Update SetupFlowController to pass error callback to confirmSetup

#52, #53) - Track all Firebase listeners via cleanup runnables in AndroidFirebase - Add removeAllListeners() to FirebaseAPI interface - Add stop() to GameNetworkHandler, called from GameScreen hide/dispose - Fix confirmSetup: propagate errors to onError callback instead of silently calling onSuccess on failure paths - Update SetupFlowController to pass error callback to confirmSetup

francinv requested review from benjamls and jonasew April 6, 2026 20:43

francinv self-assigned this Apr 7, 2026

benjamls approved these changes Apr 8, 2026

View reviewed changes

jonasew merged commit aca5c04 into development Apr 8, 2026

fix: add listener lifecycle management and confirmSetup error handling #59

fix: add listener lifecycle management and confirmSetup error handling #59

Conversation

francinv commented Apr 6, 2026